Skip to content

branch-4.1:[enhancement](filecache) filecache meta persist PRs compilation#61581

Open
freemandealer wants to merge 21 commits intoapache:branch-4.1from
freemandealer:task-branch-4-1-pick-persist-refactor
Open

branch-4.1:[enhancement](filecache) filecache meta persist PRs compilation#61581
freemandealer wants to merge 21 commits intoapache:branch-4.1from
freemandealer:task-branch-4-1-pick-persist-refactor

Conversation

@freemandealer
Copy link
Contributor

pick the following PRs/Commits:

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

freemandealer and others added 21 commits December 24, 2025 11:04
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
add check for external data (lakehouse data) when get_tablet_id
to avoid out-of-range exception

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Removed duplicate definition of file_cache_keep_schema_change_output_min_hit_ratio.
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
…o task-branch-4-1-pick-persist-refactor

# Conflicts:
#	be/src/cloud/cloud_tablet.cpp
#	be/src/exec/schema_scanner.cpp
#	be/src/io/cache/block_file_cache.cpp
#	be/src/io/cache/file_block.cpp
#	be/src/io/cache/fs_file_cache_storage.cpp
#	be/src/io/cache/fs_file_cache_storage.h
#	be/src/olap/rowset/beta_rowset_reader.cpp
#	gensrc/thrift/Descriptors.thrift
add changing type to Normal when TTL type & TTL set to 0 to make ttl
queueu size correct
1. Drop missing tablet ids on NOT_FOUND to stop repeated TTL meta
lookups and log spam
2. add bvar for tablet-id set size to monitor cleanup behavior
cache directory could be inconsistence with filecache meta store
somehow, so extend FSFileCacheStorage with inode-based stats,
leak-cleaner thread, and orphan cleanup helpers to clean such leakage.
@freemandealer freemandealer requested a review from yiguolei as a code owner March 20, 2026 12:25
@Thearas
Copy link
Contributor

Thearas commented Mar 20, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.54% (1786/2274)
Line Coverage 64.32% (31927/49641)
Region Coverage 65.15% (15983/24532)
Branch Coverage 55.72% (8501/15258)

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 65.55% (1267/1933) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.66% (19503/37036)
Line Coverage 36.13% (182327/504600)
Region Coverage 32.52% (140855/433199)
Branch Coverage 33.50% (61400/183303)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 64.83% (1224/1888) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.06% (25757/36248)
Line Coverage 53.93% (271211/502892)
Region Coverage 51.34% (224436/437171)
Branch Coverage 52.73% (96927/183823)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants