Skip to content

branch-4.1: [fix](cloud) reject ADMIN SET REPLICA VERSION in cloud #60875 #61587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Mar 21, 2026
+33 −0
Merged

branch-4.1: [fix](cloud) reject ADMIN SET REPLICA VERSION in cloud #60875 #61587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ain/java/org/apache/doris/nereids/trees/plans/commands/AdminSetReplicaVersionCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import org.apache.doris.catalog.Env;
import org.apache.doris.common.AnalysisException;
import org.apache.doris.common.DdlException;
import org.apache.doris.common.ErrorCode;
import org.apache.doris.common.ErrorReport;
import org.apache.doris.mysql.privilege.PrivPredicate;
Expand Down Expand Up @@ -132,6 +133,11 @@ private void checkProperties() throws AnalysisException {
}
}

@Override
protected void checkSupportedInCloudMode(ConnectContext ctx) throws DdlException {
throw new DdlException("Unsupported operation");
}

@Override
public <R, C> R accept(PlanVisitor<R, C> visitor, C context) {
return visitor.visitAdminSetReplicaVersionCommand(this, context);
Expand Down
27 changes: 27 additions & 0 deletions ...java/org/apache/doris/nereids/trees/plans/commands/AdminSetReplicaVersionCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
import org.apache.doris.catalog.Partition;
import org.apache.doris.catalog.Replica;
import org.apache.doris.catalog.Tablet;
import org.apache.doris.common.Config;
import org.apache.doris.common.DdlException;
import org.apache.doris.common.Pair;
import org.apache.doris.nereids.parser.NereidsParser;
import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
Expand All @@ -33,7 +35,9 @@
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

import java.util.HashMap;
import java.util.List;
import java.util.Map;

public class AdminSetReplicaVersionCommandTest extends TestWithFeService {
@Override
Expand Down Expand Up @@ -139,4 +143,27 @@ public void testAdminSetReplicaVersion() throws Exception {
Assertions.assertDoesNotThrow(() -> ((AdminSetReplicaVersionCommand) plan4).run(connectContext, null));
Assertions.assertEquals(-1L, replica.getLastFailedVersion());
}

@Test
public void testUnsupportedInCloudMode() {
String originDeployMode = Config.deploy_mode;
String originCloudUniqueId = Config.cloud_unique_id;
try {
Config.deploy_mode = "cloud";
Config.cloud_unique_id = "";

Map<String, String> properties = new HashMap<>();
properties.put("tablet_id", "1");
properties.put("backend_id", "2");
properties.put("version", "3");
AdminSetReplicaVersionCommand command = new AdminSetReplicaVersionCommand(properties);

DdlException ex = Assertions.assertThrows(DdlException.class,
() -> command.verifyCommandSupported(connectContext));
Assertions.assertTrue(ex.getMessage().contains("Unsupported operation"));
} finally {
Config.deploy_mode = originDeployMode;
Config.cloud_unique_id = originCloudUniqueId;
}
}
}
Loading