Skip to content

Branch 4.1#61595

Open
yiguolei wants to merge 24 commits intoapache:branch-4.1from
yiguolei:branch-4.1
Open

Branch 4.1#61595
yiguolei wants to merge 24 commits intoapache:branch-4.1from
yiguolei:branch-4.1

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Mar 21, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

jacktengg and others added 14 commits March 21, 2026 17:31
@jacktengg @yiguolei
[fix](decimalv2) fix wrong result of abs(decimalv2) (apache#61397) (a…
4aa3cf1 
…pache#61408)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: apache#61397

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@yiguolei
[be](refactor)refactor doris BE code structure (apache#61107)
de8456f 
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@yiguolei
fix rebase bug
b3aa22d
@yiguolei
f
711c029
@yiguolei
f
7c1ac20
@yiguolei
f
238a1fb
@yiguolei
f
c26cb7b
@yiguolei
f
9d2e796
@yiguolei
f
6232eb3
@yiguolei
f
f61b16b
@yiguolei
f
f173b62
@yiguolei
f
631407f
@yiguolei
[be](chore)fix ubsan error (apache#61127)
317a758 
ignore some ubsan error in some files.
@yiguolei
[be](ubsan) fix rowcusor ubsan error (apache#61153)
63e3dfe 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@Thearas
Copy link
Contributor

Thearas commented Mar 21, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

mymeiyi and others added 2 commits March 21, 2026 22:50
@mymeiyi @yiguolei
[fix](wal) rename wal_reader and move to wal directory (apache#61135)
8a722c3 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@yiguolei
[be](namespace) remove vecotorized and pipeline namespace (apache#61142)
0bc7d7c
yiguolei and others added 5 commits March 22, 2026 00:00
@yiguolei
f
2ecf9e1
@csun5285 @yiguolei
[fix](test) fix death tests crash in multi-threaded UT binary (apache…
2b36c0a 
…#61158)

ASSERT_DEATH/EXPECT_DEATH to crash due to unsafe fork() in
multi-threaded context.

Fix: add GTEST_FLAG_SET(death_test_style, "threadsafe") so gtest uses
fork+re-exec instead of plain fork, and setrlimit to suppress core dumps
in death test child processes.
@csun5285 @yiguolei
[fix](test) fix JsonBinaryValueTest and AcceptNullPredicateTest failu…
39fdfa3 
…res (apache#61189)

1. JsonBinaryValueTest.TestValidation: fix assertions to match parser
behavior
- Empty string and non-JSON text ('abc') correctly return error since
c3e418b refactored JsonbParser, update EXPECT_TRUE to EXPECT_FALSE
- Scalar JSON values ('1', 'null', 'false') parse successfully, keep
EXPECT_TRUE

2. AcceptNullPredicateTest: fix ODR violation with MockIndexIterator
- MockIndexIterator was defined in both accept_null_predicate_test.cpp
and function_ip_test.cpp with different has_null() implementations (true
vs false)
- Linker picked function_ip_test's vtable, causing has_null() to always
return false
- Wrap Mock classes in anonymous namespace to ensure each TU uses its
own vtable
@kaka11chen @yiguolei
[fix](test) Fix ODR violation for MockFileReader across test files. (a…
70340dd 
…pache#61170)

### What problem does this PR solve?

Problem Summary:

### Release note

Multiple test files defined different MockFileReader classes with the
same fully-qualified name doris::MockFileReader but different member
layouts and sizes (96 bytes vs 64 bytes). When linked into the single
monolithic doris_be_test binary, the linker would deduplicate symbols
and arbitrarily pick one version's template instantiations (e.g.,
make_shared, destructor), causing size mismatches at runtime. This
resulted in ASAN errors:
- heap-buffer-overflow: allocating 80 bytes but writing 96 bytes
- new-delete-type-mismatch: allocated 96 bytes, deallocated 64 bytes The
ODR conflict was exposed after apache#61142 removed the vectorized namespace,
which moved orc_file_reader_test.cpp's MockFileReader into namespace
doris, colliding with file_meta_cache_test.cpp's MockFileReader in the
same namespace.
Fix: Wrap each MockFileReader class in an anonymous namespace to give
them internal linkage, ensuring each translation unit uses its own
independent symbols.
@yiguolei
[be](refactor) move rowtype template parameter from key util (apache#…
55260b3 
…61226)

1. remove rowtype template parameter from encode key methods
2. move encode key methods from key util to rowcurosr because it only
encode rowcursor.
3. move _key_is_not_in_segment to base tablet

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@yiguolei
Copy link
Contributor Author

yiguolei commented Mar 21, 2026

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 22, 2026

BE UT Coverage Report

Increment line coverage 51.40% (140818/273955) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.62% (19488/37037)
Line Coverage 36.06% (181828/504248)
Region Coverage 32.31% (139959/433209)
Branch Coverage 33.46% (61341/183317)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yiguolei @Thearas @hello-stephen @jacktengg @mymeiyi @csun5285 @kaka11chen