[FLINK-38980][table] Migrate RemoveRedundantLocalSortAggRule to java#27474
Open
liuyongvs wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-38980][table] Migrate RemoveRedundantLocalSortAggRule to java#27474liuyongvs wants to merge 1 commit intoapache:masterfrom
liuyongvs wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
Contributor
Author
|
@flinkbot run azure |
davidradl
approved these changes
Jan 27, 2026
Contributor
|
I assume the " UnalignedCheckpointITCase.execute:280->UnalignedCheckpointTestBase.execute:198 » JobExecution Job execution failed." CI error is unrelated. |
snuyanzin
reviewed
Jan 27, 2026
Comment on lines
+129
to
+133
| b3.operand( | ||
| FlinkConventions | ||
| .BATCH_PHYSICAL() | ||
| .getInterface()) | ||
| .noInputs())))) |
Contributor
There was a problem hiding this comment.
if we compare with scala code
what about classOf[RelNode] from
operand(classOf[RelNode], FlinkConventions.BATCH_PHYSICAL, any))),?
Contributor
|
@davidradl have you compared scala vs java before approval? |
snuyanzin
requested changes
Jan 27, 2026
Contributor
snuyanzin
left a comment
There was a problem hiding this comment.
please double check against scala code
8251300 to
57a6cfe
Compare
Contributor
Author
|
@snuyanzin will you have a look again? |
1 similar comment
Contributor
Author
|
@snuyanzin will you have a look again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The PR migrates RemoveRedundantLocalSortAggRule to java
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation