Skip to content

[FLINK-38980][table] Migrate RemoveRedundantLocalSortAggRule to java#27474

Open
liuyongvs wants to merge 1 commit intoapache:masterfrom
liuyongvs:RemoveRedundantLocalSortAggRule
Open

[FLINK-38980][table] Migrate RemoveRedundantLocalSortAggRule to java#27474
liuyongvs wants to merge 1 commit intoapache:masterfrom
liuyongvs:RemoveRedundantLocalSortAggRule

Conversation

@liuyongvs
Copy link
Copy Markdown
Contributor

What is the purpose of the change

The PR migrates RemoveRedundantLocalSortAggRule to java

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Jan 27, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuyongvs
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

@davidradl
Copy link
Copy Markdown
Contributor

I assume the " UnalignedCheckpointITCase.execute:280->UnalignedCheckpointTestBase.execute:198 » JobExecution Job execution failed." CI error is unrelated.

Comment on lines +129 to +133
b3.operand(
FlinkConventions
.BATCH_PHYSICAL()
.getInterface())
.noInputs()))))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we compare with scala code
what about classOf[RelNode] from

        operand(classOf[RelNode], FlinkConventions.BATCH_PHYSICAL, any))),

?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snuyanzin what do you mean?

@snuyanzin
Copy link
Copy Markdown
Contributor

@davidradl have you compared scala vs java before approval?

Copy link
Copy Markdown
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please double check against scala code

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label Jan 27, 2026
@liuyongvs liuyongvs force-pushed the RemoveRedundantLocalSortAggRule branch from 8251300 to 57a6cfe Compare January 28, 2026 08:16
@liuyongvs
Copy link
Copy Markdown
Contributor Author

@snuyanzin will you have a look again?

1 similar comment
@liuyongvs
Copy link
Copy Markdown
Contributor Author

@snuyanzin will you have a look again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants