Skip to content

[FLINK-38981][table] Migrate BatchPhysicalSortMergeJoinRule to java#27476

Merged
snuyanzin merged 1 commit intoapache:masterfrom
liuyongvs:BatchPhysicalSortMergeJoinRule
Mar 5, 2026
Merged

[FLINK-38981][table] Migrate BatchPhysicalSortMergeJoinRule to java#27476
snuyanzin merged 1 commit intoapache:masterfrom
liuyongvs:BatchPhysicalSortMergeJoinRule

Conversation

@liuyongvs
Copy link
Copy Markdown
Contributor

What is the purpose of the change

The PR migrates BatchPhysicalSortMergeJoinRule to java

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Jan 27, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuyongvs
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

@Value.Enclosing
public class BatchPhysicalSortMergeJoinRule
extends RelRule<BatchPhysicalSortMergeJoinRule.BatchPhysicalSortMergeJoinRuleConfig>
implements BatchPhysicalJoinRuleBase {
Copy link
Copy Markdown
Contributor

@snuyanzin snuyanzin Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we migrate the whole hierarchy to avoid intermediate state when part is in java and part is in scala?

Copy link
Copy Markdown
Contributor Author

@liuyongvs liuyongvs Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snuyanzin we can step by step. BatchPhysicalJoinRuleBase has different implementation. i will migrate it to java in later pr

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label Jan 27, 2026
@liuyongvs liuyongvs force-pushed the BatchPhysicalSortMergeJoinRule branch from a84c3f9 to 5fb1e37 Compare January 28, 2026 02:26
@liuyongvs
Copy link
Copy Markdown
Contributor Author

@snuyanzin will you have a look again?

1 similar comment
@liuyongvs
Copy link
Copy Markdown
Contributor Author

@snuyanzin will you have a look again?

@snuyanzin snuyanzin merged commit ba95b2e into apache:master Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants