Skip to content

[hotfix] [metrics] Document boolean parsing and extend MetricConfigTest #27804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lurui1997 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[hotfix] [metrics] Document boolean parsing and extend MetricConfigTest #27804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/MetricConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ public double getDouble(String key, double defaultValue) {
* <p>If the value is a {@link Boolean}, it is returned directly. Otherwise, the value's string
* representation is parsed via {@link Boolean#parseBoolean(String)}.
*
* <p>Note: values stored as {@link Number} (for example {@link Integer} values produced by a
* configuration parser) are not interpreted as numeric booleans. They are converted with {@link
* Object#toString()} first, so {@code 1} becomes the string {@code "1"}, which {@link
* Boolean#parseBoolean(String)} treats as {@code false} (only {@code "true"}, case-insensitive,
* is {@code true}).
*
* @param key the hashtable key.
* @param defaultValue a default value.
* @return the value in this property list with the specified key value as a boolean.
Expand Down
12 changes: 11 additions & 1 deletion ...k-metrics/flink-metrics-core/src/test/java/org/apache/flink/metrics/MetricConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;

import java.math.BigInteger;
import java.util.stream.Stream;

import static org.assertj.core.api.Assertions.assertThat;
Expand Down Expand Up @@ -78,20 +79,29 @@ private static Stream<Arguments> fromStringCases() {
Arguments.of("3.14", (TypedGetter) (c, k) -> c.getFloat(k, 0.0f), 3.14f),
Arguments.of(
"2.718281828", (TypedGetter) (c, k) -> c.getDouble(k, 0.0), 2.718281828),
Arguments.of("true", (TypedGetter) (c, k) -> c.getBoolean(k, false), true));
Arguments.of("true", (TypedGetter) (c, k) -> c.getBoolean(k, false), true),
Arguments.of("1", (TypedGetter) (c, k) -> c.getBoolean(k, false), false));
}

private static Stream<Arguments> nativeTypeCases() {
return Stream.of(
Arguments.of(42, (TypedGetter) (c, k) -> c.getInteger(k, 0), 42),
Arguments.of((short) 8, (TypedGetter) (c, k) -> c.getInteger(k, 0), 8),
Arguments.of((byte) 3, (TypedGetter) (c, k) -> c.getInteger(k, 0), 3),
Arguments.of(
123456789012345L,
(TypedGetter) (c, k) -> c.getLong(k, 0L),
123456789012345L),
Arguments.of(3.14f, (TypedGetter) (c, k) -> c.getFloat(k, 0.0f), 3.14f),
Arguments.of(2.718281828, (TypedGetter) (c, k) -> c.getDouble(k, 0.0), 2.718281828),
Arguments.of(true, (TypedGetter) (c, k) -> c.getBoolean(k, false), true),
Arguments.of(1, (TypedGetter) (c, k) -> c.getBoolean(k, false), false),
Arguments.of(0, (TypedGetter) (c, k) -> c.getBoolean(k, true), false),
Arguments.of(42, (TypedGetter) (c, k) -> c.getString(k, "default"), "42"),
Arguments.of(
new BigInteger("9223372036854775807"),
(TypedGetter) (c, k) -> c.getLong(k, 0L),
9223372036854775807L),
Arguments.of(
123456789012345L,
(TypedGetter) (c, k) -> c.getString(k, "default"),
Expand Down