[FLINK-39308][runtime] Skip empty file-merging operator state snapshots#27814
Open
infocusmodereal wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39308][runtime] Skip empty file-merging operator state snapshots#27814infocusmodereal wants to merge 1 commit intoapache:masterfrom
infocusmodereal wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request avoids materializing file-merging operator state handles when operator list state is registered but empty.
Today
DefaultOperatorStateBackendSnapshotStrategyonly takes the empty fast path when there are no registered operator states at all. If empty operator list states are registered, file-merging checkpoints can still create tiny segment-backed handles. During restore,OperatorStateRestoreOperationopens those handles even though they contain no operator-state partitions. On object stores this adds avoidable restore overhead.Brief change log
EmptyFileMergingOperatorStreamStateHandlefor file-merging checkpoints andSnapshotResult.empty()otherwiseVerifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change added tests and can be verified as follows:
testSnapshotWithEmptyRegisteredOperatorStatetestFileMergingSnapshotRestoreWithEmptyRegisteredUnionStateJAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -pl flink-runtime -Dtest=OperatorStateBackendTest,OperatorStateRestoreOperationTest,SharedStateRegistryTest test -Djdk17 -Pjava17-targetDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation