[FLINK-39313][table] Fix NDU analyzer to detect non-deterministic functions in ChangelogNormalize filter conditions#27819
Open
gustavodemorais wants to merge 1 commit intoapache:masterfrom
Open
Conversation
…ctions in ChangelogNormalize filter conditions
Collaborator
rionmonster
approved these changes
Mar 24, 2026
Contributor
rionmonster
left a comment
There was a problem hiding this comment.
The changes look good on this end conceptually (and implementation-wise), approving! It looks like CI is showing a failure but it seems unrelated to the changes. I'll kick off another one to see if we can get a 🟢 there. Thanks!
Contributor
|
@flinkbot run azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The StreamNonDeterministicUpdatePlanVisitor treats StreamPhysicalChangelogNormalize as transparent, never inspecting its filterCondition. When the optimizer pushes a WHERE clause with a non-deterministic function (e.g. NOW()) into ChangelogNormalize on an upsert source, the filter asymmetrically drops -U records while passing +U records, corrupting the retract contract and causing incorrect results downstream.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation