[TASK-2293] use column id instead of position in Partial Update#2594
Open
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Open
[TASK-2293] use column id instead of position in Partial Update#2594fresh-borzoni wants to merge 1 commit intoapache:mainfrom
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Conversation
fresh-borzoni
force-pushed
the
partial-update-use-ids-instead-positions
branch
2 times, most recently
from
e38f9d6 to
ce0f30d
Compare
Contributor
Author
|
@loserwang1024 @luoyuxia |
fresh-borzoni
force-pushed
the
partial-update-use-ids-instead-positions
branch
6 times, most recently
from
5aa68d5 to
3345e59
Compare
fresh-borzoni
force-pushed
the
partial-update-use-ids-instead-positions
branch
from
3345e59 to
7e94b5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #2293
After ADD COLUMN,
PartialUpdaterreads old KV rows using latest-schema positions, causingArrayIndexOutOfBoundsExceptionbecause old rows have fewer fields.Solution
Convert rows to latest schema layout in
KvTabletbefore they reach the merger, using column IDs to map positions. Applied to incoming rows, old KV rows during upsert, and old KV rows during deletion. No protocol changes — server derives everything from batch'sschemaId.