[common] A custom rounding policy that reduces Arrow's chunk size fm 16MB to 4MB which same as netty arena.#2732
Merged
loserwang1024 merged 3 commits intoapache:mainfrom Apr 13, 2026
Conversation
Contributor
Author
loserwang1024
force-pushed
the
chunk-4-mb
branch
from
8e75329 to
628fffe
Compare
wuchong
reviewed
Apr 11, 2026
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Thanks @loserwang1024 , I left a comment.
Comment on lines
+120
to
+123
| new RootAllocator( | ||
| AllocationListener.NOOP, | ||
| Long.MAX_VALUE, | ||
| FlussRoundingPolicy.DEFAULT_ROUNDING_POLICY); |
Member
There was a problem hiding this comment.
I noticed that RecordAccumulator and KvManager also use the default RootAllocator constructor. Could you verify if these instances require updates as well?
If they do, please refactor the logic into a shared static method to prevent inconsistent initialization. If not, please add a comment explaining why the customized rounding policy is necessary here but not in those other components.
loserwang1024
force-pushed
the
chunk-4-mb
branch
from
d2a5288 to
fda26ae
Compare
…m 16MB to 4MB which same as netty arena.
loserwang1024
force-pushed
the
chunk-4-mb
branch
from
fda26ae to
4a542f0
Compare
wuchong
approved these changes
Apr 13, 2026
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
@loserwang1024 I pushed a commit to refactored the FlussRoundingPolicy to ArrowRoundingPolicy , and moved the BuferAllocator creator to BufferAllocatorUtil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2729
Brief change log
Tests
API and Format
Documentation