GROOVY-11871: Support Maven Resolver based version of Grapes#2140
Merged
paulk-asert merged 1 commit intoapache:masterfrom Mar 25, 2026
Merged
GROOVY-11871: Support Maven Resolver based version of Grapes#2140paulk-asert merged 1 commit intoapache:masterfrom
paulk-asert merged 1 commit intoapache:masterfrom
Conversation
paulk-asert
force-pushed
the
grapeMaven
branch
from
d2a22cf to
e1ab08e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2140 +/- ##
==================================================
- Coverage 66.6787% 66.4334% -0.2453%
- Complexity 29858 29861 +3
==================================================
Files 1382 1386 +4
Lines 116145 116595 +450
Branches 20481 20631 +150
==================================================
+ Hits 77444 77458 +14
- Misses 32358 32796 +438
+ Partials 6343 6341 -2
🚀 New features to boost your workflow:
|
paulk-asert
changed the title
paulk-asert
force-pushed
the
grapeMaven
branch
7 times, most recently
from
202953e to
eb032c8
Compare
paulk-asert
force-pushed
the
grapeMaven
branch
2 times, most recently
from
89c2a9b to
6537392
Compare
paulk-asert
force-pushed
the
grapeMaven
branch
5 times, most recently
from
40b4096 to
39ca48b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 34 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
paulk-asert
force-pushed
the
grapeMaven
branch
3 times, most recently
from
ca4c840 to
bb86131
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 37 out of 39 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+34
to
+37
| * def pretty= writer.toString() | ||
| * .replaceAll(/<\?xml[^>]*>/, '') // remove XML declaration | ||
| * assert pretty in ['<root1 a="5" b="7"><elem1>hello1</elem1><elem2>hello2</elem2><elem3 x="7"></elem3></root1>', | ||
| * '<root1 a="5" b="7"><elem1>hello1</elem1><elem2>hello2</elem2><elem3 x="7"/></root1>'] |
Comment on lines
+379
to
+392
| } catch (ReflectiveOperationException ignore) { | ||
| if (DEBUG_GRAPE) { | ||
| System.err.println "Ignoring attempt to load ConsoleIvyPlugin: ${ignore.message}" | ||
| } | ||
| } | ||
|
|
||
| // listen for Maven resolver events if the Maven console plugin is on the classpath | ||
| try { | ||
| def mavenPluginClass = Class.forName('groovy.console.ui.ConsoleMavenPlugin') | ||
| mavenPluginClass.getConstructor().newInstance().addListener(this) | ||
| } catch (ReflectiveOperationException ignore) { | ||
| if (DEBUG_GRAPE) { | ||
| System.err.println "Ignoring attempt to load ConsoleMavenPlugin: ${ignore.message}" | ||
| } |
Comment on lines
+26
to
+34
| def originalErr = System.err | ||
| def errBytes = new ByteArrayOutputStream() | ||
| try { | ||
| System.setErr(new PrintStream(errBytes, true, 'UTF-8')) | ||
| action.call() | ||
| return errBytes.toString('UTF-8') | ||
| } finally { | ||
| System.setErr(originalErr) | ||
| } |
Comment on lines
+35
to
+37
| def pretty= writer.toString() | ||
| .replaceAll(/<\?xml[^>]*>/, '') // remove XML declaration | ||
| assert pretty == '<root attribute="1"><elem1>hello</elem1><elem2>world</elem2></root>' |
paulk-asert
force-pushed
the
grapeMaven
branch
8 times, most recently
from
01caa5e to
74bd2f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide an Apache Maven Resolver alternative backend implementation for Groovy Grapes.