HBASE-30016 Cached table regions locations are not using in TableSnapshotInputFormatImpl#getSplits#7975
Open
srinireddy2020 wants to merge 1 commit intoapache:masterfrom
Open
HBASE-30016 Cached table regions locations are not using in TableSnapshotInputFormatImpl#getSplits#7975srinireddy2020 wants to merge 1 commit intoapache:masterfrom
srinireddy2020 wants to merge 1 commit intoapache:masterfrom
Conversation
…shotInputFormatImpl#getSplits
NihalJain
reviewed
Mar 25, 2026
| newConf.setInt("hbase.hconnection.threads.max", 1); | ||
| try { | ||
| List<InputSplit> splits = new ArrayList<>(); | ||
| try { |
Contributor
There was a problem hiding this comment.
can we do try-with-resources here
NihalJain
reviewed
Mar 25, 2026
| } | ||
| } | ||
| } finally { | ||
| if (connection != null) { |
Contributor
There was a problem hiding this comment.
i believe all changes are just because we added an extra block {} and code got shifted?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormatImpl#getSplits(org.apache.hadoop.hbase.client.Scan, org.apache.hadoop.hbase.snapshot.SnapshotManifest, java.util.List<org.apache.hadoop.hbase.client.RegionInfo>, org.apache.hadoop.fs.Path, org.apache.hadoop.conf.Configuration, org.apache.hadoop.hbase.util.RegionSplitter.SplitAlgorithm, int)
Connection obj is closing early. RegionLocator references are using after connection obj closed.
so that cached table regions locations are not using.