fix: Handle optional properties in load namespace properties response#3169
Open
geruh wants to merge 1 commit intoapache:mainfrom
Open
fix: Handle optional properties in load namespace properties response#3169geruh wants to merge 1 commit intoapache:mainfrom
geruh wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3167
Rationale for this change
The rest spec model
GetNamespaceResponsedefines thepropertiesfield as optional, and nullable. Also, following the description if the rest catalog doesn't support ns properties they should return null.Link: https://github.com/apache/iceberg/blob/0a73da119ff38ee3a98f248b42180caa51001cec/open-api/rest-catalog-open-api.yaml#L4146-L4163
Looks like the pydantic models raise a
ValidationErrorin the optional/null cases as seen in the issue above. So this PR adds a fix to handle these cases.Are these changes tested?
Yes, added tests and tested with s3tables api
Are there any user-facing changes?
Not really