Core: Fix rewrite_position_delete_files failure with array/map columns#15632
Open
szehon-ho wants to merge 7 commits intoapache:mainfrom
Open
Core: Fix rewrite_position_delete_files failure with array/map columns#15632szehon-ho wants to merge 7 commits intoapache:mainfrom
szehon-ho wants to merge 7 commits intoapache:mainfrom
Conversation
szehon-ho
force-pushed
the
fix_rewrite_pos_delete_nested
branch
from
9afddd3 to
a07da0f
Compare
szehon-ho
force-pushed
the
fix_rewrite_pos_delete_nested
branch
from
fee128f to
852cc81
Compare
Member
Author
|
@amogh-jahagirdar @huaxingao this was on the mailing thread as a request for Iceberg 1.10.2. can you guys help review? Thanks |
huaxingao
reviewed
Mar 20, 2026
huaxingao
reviewed
Mar 20, 2026
Contributor
|
Thanks @szehon-ho for the PR! It might be worth adding a unit test for |
- Add blank lines after control blocks (review) - Add TestExpressionUtil coverage for extractByIdInclusive - Add nested struct/list/map cases
huaxingao
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternate to #15079, avoid ExpressionUtils.identitySpec() altogether for this case to construct the metadata column's residual filter.
Fixes: #15080