Core: close entries iterable in ManifestFilterManager#15713
Open
kinolaev wants to merge 1 commit intoapache:mainfrom
Open
Core: close entries iterable in ManifestFilterManager#15713kinolaev wants to merge 1 commit intoapache:mainfrom
kinolaev wants to merge 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Sergei Nikolaev <kinolaev@gmail.com>
d7d1bd6 to
fa8978c
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents deadlocks while filtering manifest entries. The problem is
ManifestFilterManager.filterManifestin some cases reads each manifest twice: first inmanifestHasDeletedFilesand then infilterManifestWithDeletedFiles. IfmanifestHasDeletedFilesreturns in the middle of entries iterable, the underlying connection is open until the ManifestReader is closed.filterManifestmethod is called for all manifests in parallel. When number of simultaneous connections is limited (for example by http-client.apache.max-connections) it can lead to a deadlock because all connections are held bymanifestHasDeletedFiles.The problem can be reproduced using spark-sql with S3FileIO and
http-client.apache.max-connections=1: