feat(go): add TLS integration tests and examples#2898
Merged
hubcio merged 5 commits intoapache:masterfrom Mar 15, 2026
Merged
Conversation
…ion@v6 cache parameter
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2898 +/- ##
============================================
- Coverage 70.27% 70.24% -0.03%
Complexity 862 862
============================================
Files 1028 1028
Lines 85279 85280 +1
Branches 62656 62665 +9
============================================
- Hits 59932 59909 -23
- Misses 22833 22847 +14
- Partials 2514 2524 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
atharvalade
suggested changes
Mar 11, 2026
Contributor
atharvalade
left a comment
There was a problem hiding this comment.
overall lgtm but the foreign/go/client/tcp/tcp_core.go is critical imo rest are just for codebase consistency
… fix duplicate kill
atharvalade
approved these changes
Mar 11, 2026
Contributor
atharvalade
left a comment
There was a problem hiding this comment.
lgtm now! thanks @saie-ch
mmodzelewski
approved these changes
Mar 15, 2026
hubcio
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2807
Rationale
The Go SDK lacked TLS integration tests to verify encrypted TCP connections work correctly. Python and other SDKs have similar tests using
testcontainers for portable, self-contained testing.
What changed?
Before: Go SDK had no tests for TLS connections.
After: Added 3 integration tests using testcontainers that verify:
Tests use
apache/iggy:edgeDocker image by default (overridable viaIGGY_SERVER_DOCKER_IMAGEenv var) with testcontainers-go v0.32.0. In CI, the image is built from the current PR code usingdocker-build-test-serveraction.Also:
Breaking change: Bumped Go requirement from 1.23.0 to 1.25.0 (required by testcontainers-go dependency). Go 1.25.0 was released 6 months ago and is stable.
Local Execution
All TLS integration tests passed locally:
Ran complete pre-merge check suite (format, tidy, lint, tests) - all passed.
AI Usage
Claude Code (claude-sonnet-4.5)