Skip to content

IGNITE-28099 Fix eviction warning to be logged per data region #12953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oleg-vlsk wants to merge 3 commits into
base: master
Choose a base branch
from
+28 −34
Open

IGNITE-28099 Fix eviction warning to be logged per data region #12953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cf2e71
IGNITE-28099 Fix eviction warning to be logged per data region
Mar 28, 2026
addc3ca
IGNITE-28099 Move first eviction warning logic to IgniteCacheDatabase…
Apr 2, 2026
6fe421b
IGNITE-28099 Add DCL to IgniteCacheDatabaseSharedManager#ensureFreeSpace
Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 18 additions & 25 deletions ...apache/ignite/internal/processors/cache/persistence/IgniteCacheDatabaseSharedManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,12 @@ public class IgniteCacheDatabaseSharedManager extends GridCacheSharedManagerAdap
/** Page size from memory configuration, may be set only for fake(standalone) IgniteCacheDataBaseSharedManager */
private int pageSize;

/** First eviction was warned flag. */
private volatile boolean firstEvictWarn;

/** Data storege metrics. */
protected final DataStorageMetricsImpl dsMetrics;

/** */
private final Object mux = new Object();

/**
* @param ctx Kernal context.
*/
Expand Down Expand Up @@ -1247,9 +1247,22 @@ public void ensureFreeSpace(DataRegion memPlc) throws IgniteCheckedException {
return;

while (memPlc.evictionTracker().evictionRequired()) {
memPlc.metrics().onPageEvictionsStarted();
boolean shouldLog = false;

warnFirstEvict(memPlc.config());
if (!memPlc.metrics().isEvictionsStarted()) {
synchronized (mux) {
if (!memPlc.metrics().isEvictionsStarted()) {
memPlc.metrics().onPageEvictionsStarted();

shouldLog = true;
}
}
}

if (shouldLog) {
U.warn(log, "Page-based evictions started." +
" Consider increasing 'maxSize' on Data Region configuration: " + memPlc.config().getName());
}

memPlc.evictionTracker().evictDataPage();

Expand Down Expand Up @@ -1587,26 +1600,6 @@ public void lastCheckpointInapplicableForWalRebalance(int grpId) {
// No-op.
}

/**
* Warns on first eviction.
* @param regCfg data region configuration.
*/
private void warnFirstEvict(DataRegionConfiguration regCfg) {
if (firstEvictWarn)
return;

// Do not move warning output to synchronized block (it causes warning in IDE).
synchronized (this) {
if (firstEvictWarn)
return;

firstEvictWarn = true;
}

U.warn(log, "Page-based evictions started." +
" Consider increasing 'maxSize' on Data Region configuration: " + regCfg.getName());
}

/**
* Checking existence of a warm-up configuration.
*
Expand Down
19 changes: 10 additions & 9 deletions ...apache/ignite/internal/processors/cache/persistence/IgniteDataStorageMetricsSelfTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,9 +532,11 @@ public void testEvictionsStartedMetric() throws Exception {

String template = "Page-based evictions started. Consider increasing 'maxSize' on Data Region configuration: ";

LogListener lsnr = LogListener.matches(template + NO_PERSISTENCE_1).build();
LogListener lsnr1 = LogListener.matches(template + NO_PERSISTENCE_1).build();
LogListener lsnr2 = LogListener.matches(template + NO_PERSISTENCE_2).build();

listeningLog.registerListener(lsnr);
listeningLog.registerListener(lsnr1);
listeningLog.registerListener(lsnr2);

DataRegionMetrics memMetrics1 = ignite.dataRegionMetrics(NO_PERSISTENCE_1);
DataRegionMetrics memMetrics2 = ignite.dataRegionMetrics(NO_PERSISTENCE_2);
Expand All @@ -550,25 +552,24 @@ public void testEvictionsStartedMetric() throws Exception {

String big = repeat('X', 256 * 1024);

int entryCnt = 0;
int entryCntMax = 1_000_000;

for (int i = 0; i < 1_000_000 && !lsnr.check(); i++) {
for (int i = 0; i < entryCntMax && !lsnr1.check(); i++)
cacheNp1.put(i, new Person("first-" + i + "-" + big, "last-" + i + "-" + big));

entryCnt++;
}

assertTrue(lsnr.check());
assertTrue(lsnr1.check());

memMetrics1 = ignite.dataRegionMetrics(NO_PERSISTENCE_1);
memMetrics2 = ignite.dataRegionMetrics(NO_PERSISTENCE_2);

assertTrue(memMetrics1.isEvictionsStarted());
assertFalse(memMetrics2.isEvictionsStarted());

for (int i = 0; i < entryCnt + 10; i++)
for (int i = 0; i < entryCntMax && !lsnr2.check(); i++)
cacheNp2.put(i, new Person("first-" + i + "-" + big, "last-" + i + "-" + big));

assertTrue(lsnr2.check());

memMetrics1 = ignite.dataRegionMetrics(NO_PERSISTENCE_1);
memMetrics2 = ignite.dataRegionMetrics(NO_PERSISTENCE_2);

Expand Down
Loading