Skip to content

KNOX-3252: Handle duplicate object exception during postgres table cr… #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanicz merged 1 commit into from
Feb 13, 2026
Merged

KNOX-3252: Handle duplicate object exception during postgres table cr… #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gateway-server/src/main/java/org/apache/knox/gateway/GatewayMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,4 +825,7 @@ void failedToDiscoverClusterServices(String clusterName, String topologyName,

@Message(level = MessageLevel.ERROR, text = "LDAP service not found or not properly registered")
void ldapServiceNotFound();

@Message( level = MessageLevel.WARN, text = "Postgres type already exists exception caught. Tables already exist skipping creation." )
void typeAlreadyExistsCaught();
}
19 changes: 17 additions & 2 deletions ...-server/src/main/java/org/apache/knox/gateway/services/token/impl/TokenStateDatabase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@
package org.apache.knox.gateway.services.token.impl;

import org.apache.commons.codec.binary.Base64;
import org.apache.knox.gateway.GatewayMessages;
import org.apache.knox.gateway.database.DatabaseType;
import org.apache.knox.gateway.database.JDBCUtils;
import org.apache.knox.gateway.i18n.messages.MessagesFactory;
import org.apache.knox.gateway.services.security.token.KnoxToken;
import org.apache.knox.gateway.services.security.token.TokenMetadata;
import org.postgresql.util.PSQLException;

import javax.sql.DataSource;
import java.sql.Connection;
Expand All @@ -38,6 +41,9 @@
import static java.nio.charset.StandardCharsets.UTF_8;

public class TokenStateDatabase {

private static final GatewayMessages LOG = MessagesFactory.get(GatewayMessages.class);

static final String TOKENS_TABLE_NAME = "KNOX_TOKENS";
static final String TOKEN_METADATA_TABLE_NAME = "KNOX_TOKEN_METADATA";
private static final String ADD_TOKEN_SQL = "INSERT INTO " + TOKENS_TABLE_NAME + "(token_id, issue_time, expiration, max_lifetime) VALUES(?, ?, ?, ?)";
Expand All @@ -60,11 +66,20 @@ public class TokenStateDatabase {

private final DataSource dataSource;

private static final String POSTGRES_DUPLICATE_OBJECT_STATE = "42710";

TokenStateDatabase(DataSource dataSource, String dbType) throws Exception {
this.dataSource = dataSource;
DatabaseType databaseType = DatabaseType.fromString(dbType);
createTableIfNotExists(TOKENS_TABLE_NAME, databaseType.tokensTableSql());
createTableIfNotExists(TOKEN_METADATA_TABLE_NAME, databaseType.metadataTableSql());
try {
createTableIfNotExists(TOKENS_TABLE_NAME, databaseType.tokensTableSql());
Copy link
Copy Markdown
Contributor

@pzampino pzampino Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily for this PR, but I wonder if executing these in a single Statement execution might help minimize the potential for the "already exists" error while improving efficiency slightly.

Copy link
Copy Markdown
Contributor

@smolnar82 smolnar82 Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that not all the supported DB vendors have CREATE TALE IF EXISTS support (or at least this was true a couple years ago).

createTableIfNotExists(TOKEN_METADATA_TABLE_NAME, databaseType.metadataTableSql());
} catch (PSQLException psqlException) {
if (!psqlException.getSQLState().equals(POSTGRES_DUPLICATE_OBJECT_STATE)) {
throw psqlException;
}
LOG.typeAlreadyExistsCaught();
}
}

private void createTableIfNotExists(String tableName, String createSqlFileName) throws Exception {
Expand Down
Loading