You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a new table option separate_key_value_in_data_block. When set to true keys and values will be stored separately in the data block, which can result in higher cpu cache hit rate and better compression. Works best with data blocks with sufficient restart intervals and large values. Previous versions of RocksDB will reject files written using this option
Change the default value of CompactionOptionsUniversal::reduce_file_locking from false to true to improve write stall and reduce read regression
Added new virtual methods AbortAllCompactions() and ResumeAllCompactions() to the DB class
Added support for storing wide-column entity column values in blob files
Added CompactionOptionsFIFO::max_data_files_size to support FIFO compaction trimming based on combined SST and blob file sizes
Include interpolation search as an alternative to binary search, which typically performs better when keys are uniformly distributed. This is exposed as a new table option index_block_search_type. The default is binary_search.
As I see, need a code patch to use this release: /home/runner/work/kvrocks/kvrocks/src/common/db_util.h:78:7: error: address of overloaded function 'Open' cannot be static_cast to type 'rocksdb::Status (*)(const rocksdb::Options &, const std::string &, rocksdb::DB **)' (aka 'rocksdb::Status (*)(const rocksdb::Options &, const basic_string<char> &, rocksdb::DB **)') [clang-diagnostic-error] 78 | static_cast<rocksdb::Status (*)(const rocksdb::Options&, const std::string&, rocksdb::DB**)>(rocksdb::DB::Open),
I believe the public API was changed (breaking change) in version 11 (that's why it's incremented from 10 to 11):
/Users/runner/work/kvrocks/kvrocks/src/common/db_util.h:63:10: error: no matching function for call to 'OpenForReadOnly'
return rocksdb::DB::OpenForReadOnly(db_options, dbname, column_families, handles, dbptr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/kvrocks/kvrocks/build/_deps/rocksdb-src/include/rocksdb/db.h:186:17: note: candidate function not viable: no known conversion from 'rocksdb::DB **' to 'std::unique_ptr<DB> *' for 5th argument
static Status OpenForReadOnly(
^
/Users/runner/work/kvrocks/kvrocks/build/_deps/rocksdb-src/include/rocksdb/db.h:175:17: note: candidate function not viable: requires at most 4 arguments, but 5 were provided
static Status OpenForReadOnly(const Options& options, const std::string& name,
^
In file included from /Users/runner/work/kvrocks/kvrocks/src/cluster/slot_migrate.cc:26:
/Users/runner/work/kvrocks/kvrocks/src/common/db_util.h:70:10: error: no matching function for call to 'OpenAsSecondary'
return rocksdb::DB::OpenAsSecondary(db_options, dbname, secondary_path, column_families, handles, dbptr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/kvrocks/kvrocks/build/_deps/rocksdb-src/include/rocksdb/db.h:256:17: note: candidate function not viable: no known conversion from 'rocksdb::DB **' to 'std::unique_ptr<DB> *' for 6th argument
static Status OpenAsSecondary(
^
/Users/runner/work/kvrocks/kvrocks/build/_deps/rocksdb-src/include/rocksdb/db.h:221:17: note: candidate function not viable: requires 4 arguments, but 6 were provided
static Status OpenAsSecondary(const Options& options, const std::string& name,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump rocksdb to v11.0.4 (see: https://github.com/facebook/rocksdb/releases/tag/v11.0.4)
This is a first public release at 11.х line.
Key changes: