fix(hyperloglog): use namespace-prefixed key in PFMERGE GetMetadata#3441
Open
songqing wants to merge 3 commits intoapache:unstablefrom
Open
fix(hyperloglog): use namespace-prefixed key in PFMERGE GetMetadata#3441songqing wants to merge 3 commits intoapache:unstablefrom
songqing wants to merge 3 commits intoapache:unstablefrom
Conversation
Merge called GetMetadata with the raw user key instead of the namespace-prefixed key, causing the destination's existing metadata to never be found and potentially orphaning old sub-keys.
jihuayu
previously approved these changes
Apr 10, 2026
Member
|
It looks like this won't leave behind any stale data that needs manual cleanup. We can just update the code directly. |
Contributor
Author
I just add a new test to verify the fix, without the fix, the new test will fail and add comment on the test |
jihuayu
approved these changes
Apr 13, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge called GetMetadata with the raw user key instead of the namespace-prefixed key, causing the destination's existing metadata to never be found and potentially orphaning old sub-keys.