Skip to content

fix(stream): allow group and consumer names starting with digits #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
songqing wants to merge 4 commits into
base: unstable
Choose a base branch
from
+26 −7
Open

fix(stream): allow group and consumer names starting with digits #3442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48fe8f4
fix(stream): allow group and consumer names starting with digits
songqing Apr 9, 2026
d75fe93
fix test
songqing Apr 10, 2026
cbd628d
Merge branch 'unstable' into fix/stream-allow-digit-names
jihuayu Apr 11, 2026
c0c630f
Merge branch 'unstable' into fix/stream-allow-digit-names
jihuayu Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/types/redis_stream.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,9 +685,6 @@ rocksdb::Status Stream::AutoClaim(engine::Context &ctx, const Slice &stream_name
}
rocksdb::Status Stream::CreateGroup(engine::Context &ctx, const Slice &stream_name,
const StreamXGroupCreateOptions &options, const std::string &group_name) {
if (std::isdigit(group_name[0])) {
return rocksdb::Status::InvalidArgument("group name cannot start with number");
}
std::string ns_key = AppendNamespacePrefix(stream_name);

StreamMetadata metadata;
Expand Down Expand Up @@ -797,9 +794,6 @@ rocksdb::Status Stream::DestroyGroup(engine::Context &ctx, const Slice &stream_n
rocksdb::Status Stream::createConsumerWithoutLock(engine::Context &ctx, const Slice &stream_name,
const std::string &group_name, const std::string &consumer_name,
int *created_number) {
if (std::isdigit(consumer_name[0])) {
return rocksdb::Status::InvalidArgument("consumer name cannot start with number");
}
std::string ns_key = AppendNamespacePrefix(stream_name);
StreamMetadata metadata;
rocksdb::Status s = GetMetadata(ctx, ns_key, &metadata);
Expand Down
27 changes: 26 additions & 1 deletion tests/gocase/unit/type/stream/stream_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,8 @@ func TestStreamOffset(t *testing.T) {
require.Error(t, rdb.Do(ctx, "XGROUP", "CREAT", streamName, groupName, "$").Err())
require.Error(t, rdb.Do(ctx, "XGROUP", "CREATE", streamName, groupName, "$", "ENTRIEREAD", "10").Err())
require.Error(t, rdb.Do(ctx, "XGROUP", "CREATE", streamName, groupName, "$", "ENTRIESREAD", "-10").Err())
require.Error(t, rdb.Do(ctx, "XGROUP", "CREATE", streamName, "1test-group-c", "$").Err())
// Group names may start with a digit (RESP bulk string); same as Redis — not a syntax error.
require.NoError(t, rdb.Do(ctx, "XGROUP", "CREATE", streamName, "1test-group-c", "$").Err())

require.NoError(t, rdb.Del(ctx, "myStream").Err())
require.NoError(t, rdb.XAdd(ctx, &redis.XAddArgs{Stream: "myStream", Values: []string{"iTeM", "1", "vAluE", "a"}}).Err())
Expand All @@ -978,6 +979,30 @@ func TestStreamOffset(t *testing.T) {
require.Equal(t, int64(0), result)
})

t.Run("XGROUP CREATE and CREATECONSUMER with names starting with digits", func(t *testing.T) {
streamKey := "stream-digit-names"
require.NoError(t, rdb.Del(ctx, streamKey).Err())
require.NoError(t, rdb.XAdd(ctx, &redis.XAddArgs{Stream: streamKey, Values: []string{"f", "v"}}).Err())

// Group name starting with a digit should be allowed (matches Redis behavior)
require.NoError(t, rdb.XGroupCreateMkStream(ctx, streamKey, "1group", "0").Err())

// Consumer name starting with a digit should be allowed
result := rdb.Do(ctx, "XGROUP", "CREATECONSUMER", streamKey, "1group", "2consumer")
require.NoError(t, result.Err())

// Read with the digit-prefixed group and consumer
_, err := rdb.XReadGroup(ctx, &redis.XReadGroupArgs{
Group: "1group",
Consumer: "2consumer",
Streams: []string{streamKey, ">"},
Count: 10,
}).Result()
require.NoError(t, err)

require.NoError(t, rdb.Del(ctx, streamKey).Err())
})

t.Run("XGROUP CREATECONSUMER with different kinds of commands", func(t *testing.T) {
streamName := "test-stream"
groupName := "test-group"
Expand Down