feat(ts): Support IGNORE option when creating TimeSeries#3450
Open
lauk20 wants to merge 3 commits intoapache:unstablefrom
Open
feat(ts): Support IGNORE option when creating TimeSeries#3450lauk20 wants to merge 3 commits intoapache:unstablefrom
lauk20 wants to merge 3 commits intoapache:unstablefrom
Conversation
|
jihuayu
requested changes
Apr 14, 2026
Member
jihuayu
left a comment
jihuayu
left a comment
There was a problem hiding this comment.
It looks like this PR will cause backward incompatibility with old data.
We should probably draft a proposal for the storage format changes.
| GetSizedString(input, &source_key_slice); | ||
| source_key = source_key_slice.ToString(); | ||
| GetFixed64(input, &last_timestamp); | ||
| GetFixed64(input, &ignore_max_time_diff); |
Member
There was a problem hiding this comment.
This will cause compatibility issues with old data, right?
Contributor
Author
There was a problem hiding this comment.
Yes, I believe it will cause compatibility issues with old data.
One other option we have is we can add backward compatibility like so:
ignore_max_time_diff = 0;
ignore_max_val_diff = 0.0;
if (input->size() >= sizeof(uint64_t) + sizeof(double)) {
GetFixed64(input, &ignore_max_time_diff);
GetDouble(input, &ignore_max_val_diff);
}This will only Decode the values if they exist in the metadata.
How do you think we should proceed?
jihuayu
requested changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #3215.
AI Usage: AI was used to write the initial draft and tests. Manually reviewed the code logic to verify and fix issues.