add a comment to warn that it is not secure#317
Open
YYTVicky wants to merge 5 commits intoapache:trunkfrom
Open
add a comment to warn that it is not secure#317YYTVicky wants to merge 5 commits intoapache:trunkfrom
YYTVicky wants to merge 5 commits intoapache:trunkfrom
Conversation
Author
|
Hi, could I know why my PR didn't pass the checks, the PR is a comment. Our tool report that keeps checkClientTrusted and checkServerTrusted empty body is not secure. Thanks! |
Member
|
Hi @YYTVicky , Thank you for this PR! I think that was an issue with the build with all pull requests failing at that time. Can you please rebase your PR on |
Member
|
When I try to apply this patch I am getting merge conflicts. I don't there actually are any, just that the fork needs to be brought up to date. Can you please do this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.