Skip to content

MNG-11875 replace org.fusesource.jansi:jansi with org.jline:jansi#11879

Open
KevinSailema wants to merge 2 commits intoapache:maven-3.10.xfrom
KevinSailema:fix-11875-jansi-migration
Open

MNG-11875 replace org.fusesource.jansi:jansi with org.jline:jansi#11879
KevinSailema wants to merge 2 commits intoapache:maven-3.10.xfrom
KevinSailema:fix-11875-jansi-migration

Conversation

@KevinSailema
Copy link
Copy Markdown

This pull request addresses issue #11875 by replacing the dependency org.fusesource.jansi:jansi with org.jline:jansi in the Maven 3.10.x line.

Validation performed

  • Focused tests for CLI and logging paths:
    • mvn -B -pl maven-embedder,maven-slf4j-provider -am -DskipITs -Drat.skip=true -Dtest=MavenCliTest,MavenSimpleLoggerTest -Dsurefire.failIfNoSpecifiedTests=false test
  • Distribution packaging path:
    • mvn -B -V -pl apache-maven -am -DskipTests -DskipITs -Drat.skip=true package
  • Both commands completed successfully in this branch.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

  • I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
  • In any other case, please file an Apache Individual Contributor License Agreement.

@slawekjaranowski
Copy link
Copy Markdown
Member

@KevinSailema please look for my change:

In master branch we already ues jline, so your change should be targeted to branch maven-3.10.x

@KevinSailema KevinSailema changed the base branch from master to maven-3.10.x April 2, 2026 07:09
@KevinSailema KevinSailema changed the title Fix 11875 jansi migration MNG-11875 replace org.fusesource.jansi:jansi with org.jline:jansi Apr 2, 2026
@KevinSailema
Copy link
Copy Markdown
Author

KevinSailema commented Apr 2, 2026

Thanks for the guidance. I have retargeted this PR to maven-3.10.x and kept the change minimal for #11875 (single commit, 4 files). Also aligned with the migration direction discussed in #11874.

@slawekjaranowski
Copy link
Copy Markdown
Member

I'm not sure if it will working .... we still use shared-utils with old dependencies
Please push a simple commit .... CI on github was not triggered

@KevinSailema
Copy link
Copy Markdown
Author

I pushed an additional commit (797bcbe) to trigger CI as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants