Updated Go Lexer/Parser for Go Lang 1.20#7269
Open
lkishalmi wants to merge 1 commit intoapache:masterfrom
Open
Updated Go Lexer/Parser for Go Lang 1.20#7269lkishalmi wants to merge 1 commit intoapache:masterfrom
lkishalmi wants to merge 1 commit intoapache:masterfrom
Conversation
| golang.grammar.version=bcc9ec1b35e4ede2f90abdb8713a56315a634a92 | ||
|
|
||
| # Simple language update can result too many signature changes in the generated code. | ||
| sigtest.skip.gen=true |
Contributor
There was a problem hiding this comment.
Why drop the pretense that this is module has an API and require that users make dependencies implementation dependencies?
Member
There was a problem hiding this comment.
Agreed! Although I'm also curious why this is a module at all?
Member
|
fyi: i moved the milestone to NB 24 for now. (but we could squeeze this one in too if the comments are addressed since the change is isolated to go) |
Member
|
@lkishalmi dropping the milestone since it has been bumped a few times already. If you refresh this PR, feel free to add the a milestone again, there would be also still enough time to get this into NB 24 as of today. |
mbien
added
the
ci:dev-build
Member
|
lets try to get this in for NB 31 since this is a small one. adding milestone again ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the GoLang grammar from the ANTLR4 Repo, it supports Go 1.20 which has a new
~operator.