Skip to content

Comments

MINIFICPP-2725 python: fix EL with ENVIRONMENT scope#2114

Open
szaszm wants to merge 1 commit intoapache:mainfrom
szaszm:MINIFICPP-2725
Open

MINIFICPP-2725 python: fix EL with ENVIRONMENT scope#2114
szaszm wants to merge 1 commit intoapache:mainfrom
szaszm:MINIFICPP-2725

Conversation

@szaszm
Copy link
Member

@szaszm szaszm commented Feb 23, 2026

i.e. evaluation with no FlowFile context


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Signed-off-by: Marton Szasz <szaszm@apache.org>
Comment on lines +270 to 277
if flow_file is None and self.is_dynamic:
new_string_value = self.cpp_context.getDynamicProperty(self.name)
elif flow_file is None:
new_string_value = self.cpp_context.getProperty(self.name)
elif self.is_dynamic:
new_string_value = self.cpp_context.getDynamicProperty(self.name, flow_file.cpp_flow_file)
else:
new_string_value = self.cpp_context.getProperty(self.name, flow_file.cpp_flow_file)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be more readable:

if flow_file is None:
    if self.is_dynamic:
        new_string_value = self.cpp_context.getDynamicProperty(self.name)
    else:
        new_string_value = self.cpp_context.getProperty(self.name)
else:
    if self.is_dynamic:
        new_string_value = self.cpp_context.getDynamicProperty(self.name, flow_file.cpp_flow_file)
    else:
        new_string_value = self.cpp_context.getProperty(self.name, flow_file.cpp_flow_file)

or maybe even better a shorter version:

if self.is_dynamic:
    getter = self.cpp_context.getDynamicProperty
else:
    getter = self.cpp_context.getProperty

args = () if flow_file is None else (flow_file.cpp_flow_file,)

new_string_value = getter(self.name, *args)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants