Skip to content

Comments

MINIFICPP-2726 Fix HTTP S2S no data and error handling#2116

Open
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-2726
Open

MINIFICPP-2726 Fix HTTP S2S no data and error handling#2116
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-2726

Conversation

@lordgamez
Copy link
Contributor

@lordgamez lordgamez commented Feb 24, 2026

  • In case no data is sent we do not send cancel message to the remote peer, this is in line with NiFi-NiFi site to site communication
  • Handle errors in case HTTP client submit fails
  • Fix handling of 4xx and 5xx HTTP response codes: fail in case client side error code is received, only log error in case server side error is received
  • Log additional data for HTTP client communication

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

- In case no data is sent we do not send cancel message to the remote
  peer, this is in line with NiFi-NiFi site to site communication
- Handle errors in case HTTP client submit fails
- Fix handling of 4xx and 5xx HTTP response codes: fail in case client
  side error code is received, only log error in case server side error
  is received
- Log additional data for HTTP client communication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant