Skip to content

Comments

MINIFICPP-2727 Stabilize verify package tests#2117

Open
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-2727
Open

MINIFICPP-2727 Stabilize verify package tests#2117
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-2727

Conversation

@lordgamez
Copy link
Contributor

  • Remove volatile repository test for non-alpine distros, as memory management is different with glibc allocator and checking memory usage in the process does not reflect the actual memory usage of the repository
  • Do not cache errors in HTTP proxy, because transient initial connection errors can cause the proxy to always return the same error code even after establishing the connection

https://issues.apache.org/jira/browse/MINIFICPP-2727


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

- Remove volatile repository test for non-alpine distros, as memory
  management is different with glibc allocator and checking memory usage
  in the process does not reflect the actual memory usage of the
  repository
- Do not cache errors in HTTP proxy, because transient initial connection
  errors can cause the proxy to always return the same error code even after
  establishing the connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant