arch/arm64: fix compile error.#18272
Conversation
|
Hi @wangzhi16, Which architectures are affected by these changes? From what I can see, they are arm64 and x86_64, and not arm. I think this should be clarified better both in the commit title/description and in the PR summary. |
linguini1
left a comment
There was a problem hiding this comment.
Could you please show the build output before and after the change to show it is fixed?
Also, it is never sufficient to have "ostest passed" as testing information; please always include the full log output of the test formatted as a markdown code block.
There was a problem hiding this comment.
Thank you @wangzhi16 :-)
As @linguini1 noticed it is always good to attach even short logs from before and after change to show what/how/that is fixed :-)
I have updated the PR title as @simbit18 noticed it touches arm64/x86_64 not arm :-)
We may also want to update git topic to arch/[arm64,x86_64]: fix compile error. or due to CI overload merge as it not to re-trigger whole CI build again I leave that decision to the others :-)
|
please split the PR in 2 separate PRs |
cannot find : cannot find /home/work/ssd1/workspace/Vela-Multi-Boards-dev-system-CI/nuttx/arch/arm/src/crt0.o/home/work/ssd1/workspace/Vela-Multi-Boards-dev-system-CI/nuttx/arch/arm64/src/crt0.o: : No such file or directory Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
345c231
1ca6ad5 to
345c231
Compare
Summary
This patch fixes a build error in the ARM64 architecture sources where the linker reported missing or incorrectly referenced
crt0.oobjects. The change corrects the ARM64arch/arm64/srcbuild inputs so thatcrt0.ois correctly referenced and the link stage completes successfully.Why
crt0.o, causing build failures for ARM64 targets. Fixing the build inputs ensures correct object file paths and successful linking.compile error:
Impact
crt0.oreferences; enables successful ARM64 builds.Testing
compile success
ostest PASS