chore: align default credential provider API style#700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns
DefaultCredentialProvider/DefaultCredentialProviderBuilderAPI style across services usingaws-v4as the baseline.Changes
DefaultCredentialProvider::default()semantics to matchnew().default()andnew()stay equivalent.DefaultCredentialProviderBuilderfrom Volcengineprovide_credentialmodule.DefaultCredentialProviderBuilderfrom Google and Oracle crate roots.provide_credentialmodule private in Oracle and Tencent (keep public re-exports).Validation
cargo check -p reqsign-oracle -p reqsign-volcengine-tos -p reqsign-google -p reqsign-tencent-coscargo test -p reqsign-oracle test_default_matches_new