HDDS-13145. Add default javadoc:aggregate goal parameters to the root pom.xml#9704
Open
cchung100m wants to merge 2 commits intoapache:masterfrom
Open
HDDS-13145. Add default javadoc:aggregate goal parameters to the root pom.xml#9704cchung100m wants to merge 2 commits intoapache:masterfrom
cchung100m wants to merge 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Feb 11, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @cchung100m for the patch.
How was this patch tested?
N/A
Can you please include screenshot of javadoc before/after? Also, please include the command to generate javadoc.
Comment on lines
+2402
to
+2403
| <title>Hadoop Ozone Integration</title> | ||
| <packages>org.apache.hadoop.ozone*</packages> |
Contributor
There was a problem hiding this comment.
hadoop appears in org.apache.hadoop.ozone for historical reason (Ozone started as sub-project of Hadoop), it's not related to integration with Hadoop. I don't think we need this grouping.
Comment on lines
+2408
to
+2409
| <reportOutputDirectory>${project.build.directory}/site</reportOutputDirectory> | ||
| <destDir>ozone-main/api</destDir> |
Contributor
There was a problem hiding this comment.
hadoop-project/api makes sense for Hadoop, because hadoop-project dir exists and contains a module. ozone-main module is not in the ozone-main dir, but in the root dir.
Isn't the default output directory fine?
Suggested change
| <reportOutputDirectory>${project.build.directory}/site</reportOutputDirectory> | |
| <destDir>ozone-main/api</destDir> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add default javadoc:aggregate goal parameters to the root pom.xml
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13145
How was this patch tested?
N/A