-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[python] support read after update by shard of data evolution table #7157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| row_tracking_enabled: bool, | ||
| system_fields: dict): | ||
| system_fields: dict, | ||
| requested_field_names: Optional[List[str]] = None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should just use fields: List[DataField]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should just use
fields: List[DataField]?
Updated
| """Ensure _ROW_ID and _SEQUENCE_NUMBER are not null (per SpecialFields).""" | ||
| fields = [] | ||
| for field in schema: | ||
| if field.name == SpecialFields.ROW_ID.name or field.name == SpecialFields.SEQUENCE_NUMBER.name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it can be nullable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it can be nullable?
A bug here. Nullable info of row-tracking system fields is lost during _assign_row_tracking. Opened a separate PR #7174 to fix it.
befde12 to
72ffd99
Compare
72ffd99 to
7e5f55a
Compare
Problem
When the user updates a column for only one shard (e.g. ShardTableUpdator runs shard 0 only and writes new column
d), full table read fails:Only that shard’s files have the new column; other files do not. Concat batches → schema mismatch → crash. To fix the issue, we support data evolution shard read.
Tests
API and Format
Documentation