PHOENIX-7767,PHOENIX-7768 Change default states for ACTIVE and STANDBY roles and Add HDFSUrl and PeerHDFSUrl to HA Record#2381
Conversation
…Y roles and Add HDFSUrl and PeerHDFSUrl to HA Record
| return adminCRRVersion; | ||
| } | ||
|
|
||
| public String getHdfsUrl() { |
There was a problem hiding this comment.
@ritegarg We also need to modify ReplicationLogGroup to read the hdfs urls from the HAGroupStoreRecord instead of the config. https://github.com/apache/phoenix/blob/PHOENIX-7562-feature-new/phoenix-core-server/src/main/java/org/apache/phoenix/replication/ReplicationLogGroup.java#L770-L776
There was a problem hiding this comment.
ReplicationLogGroup is already fetching the HAGroupStoreRecord to find the state. https://github.com/apache/phoenix/blob/PHOENIX-7562-feature-new/phoenix-core-server/src/main/java/org/apache/phoenix/replication/ReplicationLogGroup.java#L448-L452
We might need to do a little bit of refactoring.
There was a problem hiding this comment.
Discussed offline, this will be taken care of in a separate PR.
|
There is a test failure https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2381/8/testReport/org.apache.phoenix.jdbc/HAGroupStoreManagerIT/testGetHAGroupStoreRecord/ It might be a flapper but still needs to be addressed |
3 participants
No description provided.