Conversation
|
@adutra Thanks for the review! Ready to merge. |
|
@snazy Hi! This PR has passed all CI checks and has one approval. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Unfortunately we forgot to merge this PR and now it has some conflicts. @kavya-seth-vns apologies for that, but would you be able to fix the conflicts? |
|
I think it's fine to merge this one now, the site-guides CI workflow didn't show up as problematic, so I think we can consider it to be stable. It's not a big conflict, @kavya-seth-vns mind resolving it? |
jbonofre
left a comment
There was a problem hiding this comment.
LGTM, and it makes sense to merge.
|
@kavya-seth-vns can you please rebase and fix conflict? |
Summary
Fixes #3981
This PR moves the Site Guides workflow into the main CI workflow so that the guide tests run as part of the mandatory CI checks.
Changes
test-site-guidesjob to.github/workflows/ci.yml..github/workflows/site-guides.ymlworkflow.Testing
The workflow was manually triggered and verified that all site guide tests pass successfully.
Checklist
site-guides.ymlworkflow intoci.yml#3981CHANGELOG.md(not required for CI workflow changes)site/content/in-dev/unreleased(not required)