Skip to content

Move site guides to ci#3988

Open
kavya-seth-vns wants to merge 5 commits intoapache:mainfrom
kavya-seth-vns:move-site-guides-to-ci
Open

Move site guides to ci#3988
kavya-seth-vns wants to merge 5 commits intoapache:mainfrom
kavya-seth-vns:move-site-guides-to-ci

Conversation

@kavya-seth-vns
Copy link
Copy Markdown

Summary

Fixes #3981

This PR moves the Site Guides workflow into the main CI workflow so that the guide tests run as part of the mandatory CI checks.

Changes

  • Added the test-site-guides job to .github/workflows/ci.yml.
  • Removed the standalone .github/workflows/site-guides.yml workflow.
  • Ensured the site guides tests run as part of the required CI checks.

Testing

The workflow was manually triggered and verified that all site guide tests pass successfully.

Checklist

  • 🛡️ Don't disclose security issues! (contact [security@apache.org](mailto:security@apache.org))
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes Move site-guides.yml workflow into ci.yml #3981
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic (not needed for this change)
  • 🧾 Updated CHANGELOG.md (not required for CI workflow changes)
  • 📚 Updated documentation in site/content/in-dev/unreleased (not required)

@github-project-automation github-project-automation Bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Mar 12, 2026
@kavya-seth-vns kavya-seth-vns marked this pull request as draft March 12, 2026 14:43
@kavya-seth-vns kavya-seth-vns marked this pull request as ready for review March 12, 2026 14:43
@kavya-seth-vns kavya-seth-vns marked this pull request as draft March 12, 2026 14:44
@kavya-seth-vns kavya-seth-vns marked this pull request as ready for review March 12, 2026 14:45
@kavya-seth-vns
Copy link
Copy Markdown
Author

@adutra Thanks for the review! Ready to merge.

@dimas-b dimas-b requested a review from snazy March 12, 2026 16:01
@kavya-seth-vns
Copy link
Copy Markdown
Author

@snazy Hi! This PR has passed all CI checks and has one approval.
If everything looks good to you, it should be ready to merge. Thanks!

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions Bot added the stale label Apr 14, 2026
@adutra
Copy link
Copy Markdown
Contributor

adutra commented Apr 14, 2026

Unfortunately we forgot to merge this PR and now it has some conflicts. @kavya-seth-vns apologies for that, but would you be able to fix the conflicts?

@adutra adutra removed the stale label Apr 14, 2026
@snazy
Copy link
Copy Markdown
Member

snazy commented Apr 15, 2026

I think it's fine to merge this one now, the site-guides CI workflow didn't show up as problematic, so I think we can consider it to be stable.

It's not a big conflict, @kavya-seth-vns mind resolving it?

Copy link
Copy Markdown
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and it makes sense to merge.

@jbonofre
Copy link
Copy Markdown
Member

@kavya-seth-vns can you please rebase and fix conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move site-guides.yml workflow into ci.yml

4 participants