(#8594) - plugin override built-in methods#8648
Open
EthanDawes wants to merge 2 commits intoapache:masterfrom
Open
(#8594) - plugin override built-in methods#8648EthanDawes wants to merge 2 commits intoapache:masterfrom
EthanDawes wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
@funblaster22 The build is failing consistently with this change. Can you have another look? |
Contributor
|
@garethbowen The problem is probably that the plugin override is globally registered. Let me open a new PR with another test. |
Contributor
|
@louwers That'd be my guess too. It may need an after/aftereach to unregister the plugin after the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some test cases for the issue. I implemented the solution by storing the prototype of
PouchDBat the start of the constructor, and then redeclaring the plugin methods from the stored prototype at the end of the constructor.This resolves #8594
This is the continuation of #8631 which was accidently closed when I rebased. I rebased from a commit that didn't have CI errors. However, local
npm teststill throws errors when running from master. 🤷