This repository was archived by the owner on May 12, 2021. It is now read-only.
[PIO-138] Fix batchpredict for custom PersistentModel#447
Open
mars wants to merge 1 commit intoapache:developfrom
Open
[PIO-138] Fix batchpredict for custom PersistentModel#447mars wants to merge 1 commit intoapache:developfrom
mars wants to merge 1 commit intoapache:developfrom
Conversation
Member
Author
|
I'm currently testing this change with various engines and large batches. |
Member
Author
|
Tested this new
This PR is ready to go! |
Member
Author
|
BTW, I found performance for a large, 250K query batch running on a single multi-core machine is equivalent to the previous Spark RDD-based performance. |
Member
Author
|
This PR stalled due to @dszeto's concerns about removing the distributed processing capability from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PIO-138
Switches batch query processing from Spark RDD to a Scala parallel collection. As a result, the
pio batchpredictcommand changes in the following ways:--query-partitionsoption is no longer available; parallelism is now managed by Scala's parallel collections--inputoption is now read as a plain, local file--outputoption is now written as a plain, local fileThis solves the root problem that certain custom PersistentModels, such as ALS Recommendation template, may themselves contain RDDs, which cannot be nested inside the batch queries RDD. (See SPARK-5063)