[ISSUE #10208] Fix resource leak in IOTinyUtils.copyFile#10210
Open
daguimu wants to merge 1 commit intoapache:developfrom
Open
[ISSUE #10208] Fix resource leak in IOTinyUtils.copyFile#10210daguimu wants to merge 1 commit intoapache:developfrom
daguimu wants to merge 1 commit intoapache:developfrom
Conversation
FileInputStream and FileOutputStream were created inline as arguments to getChannel(), losing the stream references. If an exception occurs between the two stream creations, the first stream leaks. Refactored to use try-with-resources for proper resource management. Fixes apache#10208
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
IOTinyUtils.copyFile(),FileOutputStreamandFileInputStreamare created inline:The underlying stream references are lost. If
new FileInputStream(sf)throws an exception (e.g., file locked), the already-createdFileOutputStreamand its channel will never be closed, leaking a file descriptor. Thefinallyblock only closes theFileChannelvariables, which may be null at that point.Root Cause
Stream objects are not stored in variables and therefore cannot be closed in the
finallyblock if an exception occurs between their creation.Fix
Refactored to use try-with-resources, which ensures all four resources (
FileInputStream,FileOutputStream, and their channels) are properly closed in all cases:Tests Added
No new tests needed — existing
IOTinyUtilsTest.testCopyFile()covers the normal path and passes with the refactored code. The fix is a pure resource management improvement.Impact
Fixes #10208