Skip to content

Remove GroupBy.field_name from BanyanDB MeasureQuery request building #13786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-sheng merged 1 commit into from
Apr 3, 2026
Merged

Remove GroupBy.field_name from BanyanDB MeasureQuery request building #13786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/en/changes/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* Add Zipkin Virtual GenAI e2e test. Use `zipkin_json` exporter to avoid protobuf dependency conflict
between `opentelemetry-exporter-zipkin-proto-http` (protobuf~=3.12) and `opentelemetry-proto` (protobuf>=5.0).
* Fix missing `taskId` filter and incorrect `IN` clause parameter binding in `JDBCJFRDataQueryDAO` and `JDBCPprofDataQueryDAO`.
* Remove deprecated `GroupBy.field_name` from BanyanDB `MeasureQuery` request building (Phase 1 of staged removal across repos).

#### UI

Expand Down
1 change: 0 additions & 1 deletion ...b-client/src/main/java/org/apache/skywalking/library/banyandb/v1/client/MeasureQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ BanyandbMeasure.QueryRequest build() throws BanyanDBException {
throw new IllegalArgumentException("field name cannot be null or empty if aggregation is specified");
}
} else {
groupByBuilder.setFieldName(this.aggregation.fieldName);
BanyandbMeasure.QueryRequest.Aggregation aggr = BanyandbMeasure.QueryRequest.Aggregation.newBuilder()
.setFunction(this.aggregation.aggregationType.function)
.setFieldName(this.aggregation.fieldName)
Expand Down
Loading