Skip to content

Fix for defect SOLR-18186: Solr heap used percentage uses committed heap instead of max heap which raises false alarm#4257

Open
raviranjanjha wants to merge 3 commits intoapache:mainfrom
raviranjanjha:main
Open

Fix for defect SOLR-18186: Solr heap used percentage uses committed heap instead of max heap which raises false alarm#4257
raviranjanjha wants to merge 3 commits intoapache:mainfrom
raviranjanjha:main

Conversation

@raviranjanjha
Copy link
Copy Markdown

@raviranjanjha raviranjanjha commented Apr 1, 2026

https://issues.apache.org/jira/browse/SOLR-18186

Description

Solr heap used percentage uses committed heap instead of max heap.

Solution

Fixed cloud.js to use max heap (-Xmx) value instead of committed heap. Also fixed the display and tooltip in cloud.html

Tests

Tested fixed build

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

@epugh
Copy link
Copy Markdown
Contributor

epugh commented Apr 1, 2026

Change Lgtm but could you add some context on why metric change? Sort of curious why we chose the wrong value... any articles or links on how to calculate this value I can read up on.

@raviranjanjha
Copy link
Copy Markdown
Author

raviranjanjha commented Apr 1, 2026 via email

@epugh epugh self-assigned this Apr 1, 2026
@epugh
Copy link
Copy Markdown
Contributor

epugh commented Apr 1, 2026

Your explanation makes more sense to me! I'm going to leave it open for a few days, see if anyone else chimes in. Can you add the changelog entry?

@raviranjanjha
Copy link
Copy Markdown
Author

Done. Added the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants