Fix for defect SOLR-18186: Solr heap used percentage uses committed heap instead of max heap which raises false alarm#4257
Open
raviranjanjha wants to merge 3 commits intoapache:mainfrom
Open
Fix for defect SOLR-18186: Solr heap used percentage uses committed heap instead of max heap which raises false alarm#4257raviranjanjha wants to merge 3 commits intoapache:mainfrom
raviranjanjha wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
|
Change Lgtm but could you add some context on why metric change? Sort of curious why we chose the wrong value... any articles or links on how to calculate this value I can read up on. |
Author
|
Hey Eric,
Not sure why originally committed heap was chosen to compute the heap used
percentage, but surely its been around for quite some time.
As I explained in ticket too, unless we move to using max heap metric, it
might show a warning in red for even very low heap use just because the
solr never requested high heap from OS (committed heap).
- Committed heap is the total amount of memory currently reserved from
the operating system for the Java process.
- Reference:
https://stackoverflow.com/questions/41468670/difference-in-used-committed-and-max-heap-memory#:~:text=committed:%20amount%20of%20memory%20that,for%20the%20java%20process%20anyway
.
…On Wed, 1 Apr, 2026, 4:25 pm Eric Pugh, ***@***.***> wrote:
*epugh* left a comment (apache/solr#4257)
<#4257?email_source=notifications&email_token=AAWXHAZFZALROOQRZ6WEZDL4TTYRFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJWHEZDEOBRGEY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4169228111>
Change Lgtm but could you add some context on why metric change? Sort of
curious why we chose the wrong value... any articles or links on how to
calculate this value I can read up on.
—
Reply to this email directly, view it on GitHub
<#4257?email_source=notifications&email_token=AAWXHAZFZALROOQRZ6WEZDL4TTYRFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJWHEZDEOBRGEY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4169228111>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWXHA4OYBH2GSHYACEKOC34TTYRFAVCNFSM6AAAAACXJAUBL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNRZGIZDQMJRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Your explanation makes more sense to me! I'm going to leave it open for a few days, see if anyone else chimes in. Can you add the changelog entry? |
Author
|
Done. Added the changelog |
janhoy
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18186
Description
Solr heap used percentage uses committed heap instead of max heap.
Solution
Fixed cloud.js to use max heap (-Xmx) value instead of committed heap. Also fixed the display and tooltip in cloud.html
Tests
Tested fixed build
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.