SOLR-18121: Rm 'rm-in-advance' fetcher codepath#4258
Open
gerlowskija wants to merge 1 commit intoapache:mainfrom
Open
SOLR-18121: Rm 'rm-in-advance' fetcher codepath#4258gerlowskija wants to merge 1 commit intoapache:mainfrom
gerlowskija wants to merge 1 commit intoapache:mainfrom
Conversation
Prior to this commit, the IndexFetcher had support for an edge case where if a full-index-fetch was needed but the receiving host didn't have adequate disk space, then the IndexFetcher would delete the existing (out of date) copy of the index to free up space. Unfortunately, this optimization/"feature" was never documented in the ref-guide, had very little test coverage, and contained a number of resource-leaks that appeared to trigger 100% of the time. While the feature might've worked when initially written, the rare-ness of the triggering condition and lack of tests had led to some severe bitrot over time. This commit removes this optimization, largely by walking back changes in 'b061947' which added it initially.
Contributor
Author
|
Note to self that tests and check pass on this already. Not sure whether this merits a changelog entry or not. In theory it's a removal that folks would care about if they were relying on it. But given that it was undocumented and (afaict) 100% broken, I don't think anyone could rely on it. So a changelog entry would largely just be noise. |
dsmiley
reviewed
Apr 2, 2026
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
Of course we should articulate that we removed this (broken) feature. No matter how broken, the flag for it was there and some people thought it worked. Yes a changelog, yes a note in major-changes-in....adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18121
Description
Prior to this commit, the IndexFetcher had support for an edge case where if a full-index-fetch was needed but the receiving host didn't have adequate disk space, then the IndexFetcher would delete the existing (out of date) copy of the index to free up space.
Unfortunately, this optimization/"feature" was never documented in the ref-guide, had very little test coverage, and contained a number of resource-leaks that appeared to trigger 100% of the time. While the feature might've worked when initially written, the rare-ness of the triggering condition and lack of tests had led to some severe bitrot over time.
Solution
This commit removes the code for this optimization altogether. It largely works by walking back the code introduced in the original change, 'b061947'.
Tests
No new tests; removal of existing test
TestReplicationHandlerDiskOverFlow.Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.