SOLR-18188: Remove tests for HttpSolrClient etc.#4261
Open
dsmiley wants to merge 3 commits intoapache:mainfrom
Open
SOLR-18188: Remove tests for HttpSolrClient etc.#4261dsmiley wants to merge 3 commits intoapache:mainfrom
dsmiley wants to merge 3 commits intoapache:mainfrom
Conversation
Removes package org.apache.solr.client.solrj.apache in solr-test-framework's tests. They are deprecated anyway. Removing this code now helps us remove HttpSolrClient itself and do other migrations without needless work here.
Contributor
|
So none of these tests need to be migrated to the updated Http Solr Client? I woudn't have guessed that these could all be delete versus updated. |
Contributor
Author
|
Notice the Java package they are in. I put them into this package late last year so as to clearly delineate HttpSolrClient related things from our other clients. |
Contributor
|
I see, so these tests exist for out other clients, these were just the |
Only for org.apache.solr.client.solrj.apache.LBHttpSolrClient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes package org.apache.solr.client.solrj.apache in solr-test-framework's tests. They are deprecated anyway.
Removing this code now helps us eventually remove HttpSolrClient.
https://issues.apache.org/jira/browse/SOLR-18188