Skip to content

[SPARK-56401] Use setup-gradle v6.1.0 GitHub Actions in CIs#621

Closed
dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
dongjoon-hyun:SPARK-56401
Closed

[SPARK-56401] Use setup-gradle v6.1.0 GitHub Actions in CIs#621
dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
dongjoon-hyun:SPARK-56401

Conversation

@dongjoon-hyun
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun commented Apr 8, 2026

What changes were proposed in this pull request?

This PR adds gradle/actions/setup-gradle to GitHub Actions workflows (build_and_test.yml, publish_snapshot_chart.yml) and removes the cache: 'gradle' option from actions/setup-java and Java Tool Chain caching step since setup-gradle handles Gradle caching.

Why are the changes needed?

The gradle/actions/setup-gradle action is the officially recommended way to set up Gradle in GitHub Actions, offering several advantages over the cache: 'gradle' option in actions/setup-java:

Advantages:

  • More efficient caching: Provides more sophisticated and optimized caching of Gradle User Home between invocations, with detailed reporting of cache usage and configuration options.
  • Dependency Graph support: Can generate and submit a GitHub Dependency Graph for the project, enabling Dependabot security alerts.
  • Build Scan link capture: Automatically captures Build Scan links from the build, making them easier to locate in workflow runs.
  • Separation of concerns: actions/setup-java is a general-purpose Java setup tool. Delegating Gradle-specific setup to the dedicated first-party action avoids sub-optimal caching strategies (actions/setup-java#588).

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI should pass with the updated workflows.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (claude-opus-4-6)

viirya
viirya previously approved these changes Apr 8, 2026
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Oh, it seems that there is a discussion in ASF Infra team about this action currently. I'm going to hold this PR a little while monitoring the ASF Infra team.

@dongjoon-hyun dongjoon-hyun marked this pull request as draft April 8, 2026 21:37
@viirya viirya dismissed their stale review April 8, 2026 21:42

stale

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Thank you for reviewing this, @viirya .

For the record, here is the ASF Infra discussion thread.

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

ASF Infra team decided to support 6.1.0. I'm currently waiting for the ASF Infra's update procedure to consume 6.1.0 directly.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-56401] Use setup-gradle GitHub Actions in CIs [SPARK-56401] Use setup-gradle v6.1.0 GitHub Actions in CIs Apr 15, 2026
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review April 15, 2026 15:40
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Apr 15, 2026

Finally, v6.1.0 is allowed.

https://github.com/apache/infrastructure-actions/blob/18e77ef52929315c1ad206a97dcbd7fbbcc98136/actions.yml#L440-L441

  50e97c2cd7a37755bbfafc9c5b7cafaece252f6e:
    tag: v6.1.0

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Could you review this PR, @peter-toth ?

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Thank you, @peter-toth !

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Thank you, @viirya , too.

@dongjoon-hyun dongjoon-hyun added this to the 0.9.0 milestone Apr 15, 2026
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Merged to main

@dongjoon-hyun dongjoon-hyun deleted the SPARK-56401 branch April 15, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants