[SPARK-56057] Fix TLS Memory Leak#54894
Open
akpatnam25 wants to merge 2 commits intoapache:masterfrom
Open
Conversation
Author
|
+CC @mridulm |
Author
|
+CC @SteNicholas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Celeborn currently uses the same code as Spark for TLS support. We encountered a memory leak there (see PR apache/celeborn#3630).
I am contributing this to Spark in order to keep parity, given that the TLS implementation is the same.
Essentially, the fix for this issue is to release the original message body, so that the net reference count is preserved. The second reference — now living inside the composite buffer in out — keeps the memory alive while Netty writes it to the network. When Netty finishes and releases the composite, the count reaches 0 and the memory is freed cleanly.
This is exactly what the non-SSL MessageEncoder already does via MessageWithHeader.deallocate() — the SSL path simply needed to replicate that behavior explicitly.
Why are the changes needed?
fix memory leak
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
no
How was this patch tested?
already internally in production and tested.
Also added unit tests
Was this patch authored or co-authored using generative AI tooling?
no