Remove redundant closeOperation for abandoned executions#54924
Draft
terana wants to merge 1 commit intoapache:masterfrom
Draft
Remove redundant closeOperation for abandoned executions#54924terana wants to merge 1 commit intoapache:masterfrom
terana wants to merge 1 commit intoapache:masterfrom
Conversation
Ordering with executions.remove doesn't matter for abandoned operations, since a concurrent operation retry will find the thombtone and fail anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove redundant closeOperation call because it is being called unconditionally right after exiting from if-clause (line 167 of the original file).
This redundant call was initially added in #52232
Ordering with executions.remove doesn't matter for abandoned operations,
since a concurrent operation retry will find the thombtone and fail anyway.
Why are the changes needed?
Leave code in cleaner state.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No tests added, relying on existing ones.
Was this patch authored or co-authored using generative AI tooling?
No.