[SPARK-56113][PS] Improve pandas 3 string restoration in pandas-on-Spark#54926
Open
ueshin wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-56113][PS] Improve pandas 3 string restoration in pandas-on-Spark#54926ueshin wants to merge 2 commits intoapache:masterfrom
ueshin wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates string restoration in
python/pyspark/pandas/data_type_ops/string_ops.pyso string columns are restored with the pandas dtype carried in the internal field when converting back to pandas in pandas 3 environments.This improves pandas 3 compatibility for string round-trips and also fixes downstream cases where restored string-related metadata could differ from pandas behavior.
Why are the changes needed?
pandas 3 is stricter about string dtype restoration and missing-value handling.
In pandas-on-Spark, converting string data back to pandas should preserve the intended pandas dtype instead of falling back to less precise restoration behavior. Without that, pandas 3 comparisons can fail even when the underlying values match.
Does this PR introduce any user-facing change?
Yes, it will behave more like pandas 3.
How was this patch tested?
Added the related tests and the other existing tests should pass.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex GPT-5