TEZ-4691: Upgrade maven-checkstyle-version to 3.6.0 by Aggarwal-Raghav · Pull Request #463 · apache/tez

Aggarwal-Raghav · 2026-03-09T11:04:48Z

Check TEZ-4691 for details

Aggarwal-Raghav · 2026-03-09T11:06:15Z

pom.xml

    <build-helper-maven-plugin.version>1.8</build-helper-maven-plugin.version>
    <buildnumber-maven-plugin.version>1.1</buildnumber-maven-plugin.version>
-    <checkstyle.version>8.35</checkstyle.version>
+    <checkstyle.version>13.3.0</checkstyle.version>


I didn't removed puppycrawler explicit dependency as it is present in offical doc as well and based on google maven-checkstyle-version have 9.3 as default puppycrawler version. For now I have moved it to latest 13.3.0.
https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html

abstractdog · 2026-03-09T11:06:50Z

LGTM, pending tests

Aggarwal-Raghav · 2026-03-09T11:07:26Z

Will check the first CI run to confirm if checkstyle fails because of plexus-velocity or not

Aggarwal-Raghav · 2026-03-09T14:22:57Z

@abstractdog , tez CI is asking for login (seeing it for first time). How to login/bypass it?

abstractdog · 2026-03-09T14:44:52Z

@abstractdog , tez CI is asking for login (seeing it for first time). How to login/bypass it?

not sure, have to check what changed on ci-hadoop

I'm monitoring the corresponding job in the meantime, but it's not yet started, because jenkins is about to shut down

tez-yetus · 2026-03-10T09:48:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	17m 59s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ master Compile Tests _
+1 💚	mvninstall	11m 40s		master passed
+1 💚	compile	3m 16s		master passed
+1 💚	javadoc	1m 43s		master passed
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 54s		the patch passed
+1 💚	codespell	2m 14s		No new issues.
+1 💚	compile	2m 33s		the patch passed
+1 💚	javac	2m 33s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	javadoc	1m 20s		the patch passed
			_ Other Tests _
+1 💚	unit	73m 31s		root in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		121m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/1/artifact/out/Dockerfile
GITHUB PR	#463
Optional Tests	dupname asflicense javac javadoc unit codespell detsecrets xmllint compile
uname	Linux 6a5d39947b97 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-463/src/.yetus/personality.sh
git revision	master / `7dd38f9`
Default Java	Ubuntu-21.0.10+7-Ubuntu-124.04
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/1/testReport/
Max. process+thread count	1335 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/1/console
versions	git=2.43.0 maven=3.8.7 codespell=2.4.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

abstractdog · 2026-03-10T10:42:12Z

@Aggarwal-Raghav : a bit concerned that checkstyle hasn't been triggered by this commit: can you please add an artifical style issue (e.g. bad indentation to a random class) to see if it fails and correctly reports 1 additional issue (I see how uncomfortable to bother with commits like this, this is what it is at the moment)

if it works, you can remove the extra commit and we can merge ASAP

Aggarwal-Raghav · 2026-03-10T10:47:57Z

@Aggarwal-Raghav : a bit concerned that checkstyle hasn't been triggered by this commit: can you please add an artifical style issue (e.g. bad indentation to a random class) to see if it fails and correctly reports 1 additional issue (I see how uncomfortable to bother with commits like this, this is what it is at the moment)

if it works, you can remove the extra commit and we can merge ASAP

no worries at all. one doubt, if i make any java changes then it will trigger right? Maybe I can fix 1 checkstyle in a java class 😅

tez-yetus · 2026-03-10T13:19:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	7m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ master Compile Tests _
+0 🆗	mvndep	2m 25s		Maven dependency ordering for branch
+1 💚	mvninstall	10m 9s		master passed
+1 💚	compile	3m 7s		master passed
+1 💚	checkstyle	1m 28s		master passed
+1 💚	javadoc	1m 58s		master passed
+0 🆗	spotbugs	2m 34s		tez-dag in master has 749 extant spotbugs warnings.
+0 🆗	spotbugs	7m 49s		root in master has 1935 extant spotbugs warnings.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 30s		the patch passed
+1 💚	codespell	1m 48s		No new issues.
+1 💚	compile	3m 14s		the patch passed
+1 💚	javac	3m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/buildtool-patch-checkstyle-tez-dag.txt	The patch fails to run checkstyle in tez-dag
-0 ⚠️	checkstyle	0m 19s	/buildtool-patch-checkstyle-root.txt	The patch fails to run checkstyle in root
+1 💚	javadoc	1m 50s		the patch passed
+1 💚	spotbugs	9m 59s		the patch passed
			_ Other Tests _
-1 ❌	unit	6m 34s	/patch-unit-tez-dag.txt	tez-dag in the patch passed.
-1 ❌	unit	75m 20s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	0m 56s		The patch does not generate ASF License warnings.
		146m 8s

Reason	Tests
Failed junit tests	tez.dag.history.recovery.TestRecoveryService
	tez.dag.history.recovery.TestRecoveryService

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/2/artifact/out/Dockerfile
GITHUB PR	#463
Optional Tests	dupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
uname	Linux fc48d4c5e33b 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-463/src/.yetus/personality.sh
git revision	master / `b7dddb9`
Default Java	Ubuntu-21.0.10+7-Ubuntu-124.04
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/2/testReport/
Max. process+thread count	1422 (vs. ulimit of 5500)
modules	C: tez-dag . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/2/console
versions	git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.4.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

abstractdog · 2026-03-10T13:33:28Z

https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/2/artifact/out/buildtool-patch-checkstyle-tez-dag.txt
oh no, this is something similar to what we saw in case of spotbugs in TEZ-4669
#457

do you have the bandwidth to investigate it @Aggarwal-Raghav ?

Aggarwal-Raghav · 2026-03-10T13:36:26Z

https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/2/artifact/out/buildtool-patch-checkstyle-tez-dag.txt
oh no, this is something similar to what we saw in case of spotbugs in TEZ-4669
#457

do you have the bandwidth to investigate it @Aggarwal-Raghav ?

Yes, I know this and observed in #462 as well. Just wanted to confirm without apache 37 parent pom it is happening. Will update PR shortly

#463 (comment)

tez-yetus · 2026-03-10T16:34:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 15s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ master Compile Tests _
+0 🆗	mvndep	2m 31s		Maven dependency ordering for branch
+1 💚	mvninstall	10m 18s		master passed
+1 💚	compile	3m 20s		master passed
+1 💚	checkstyle	1m 25s		master passed
+1 💚	javadoc	1m 56s		master passed
+0 🆗	spotbugs	2m 24s		tez-dag in master has 749 extant spotbugs warnings.
+0 🆗	spotbugs	7m 19s		root in master has 1935 extant spotbugs warnings.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 8s		the patch passed
+1 💚	codespell	1m 48s		No new issues.
+1 💚	compile	3m 4s		the patch passed
+1 💚	javac	3m 4s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 51s	/results-checkstyle-tez-dag.txt	tez-dag: The patch generated 2 new + 66 unchanged - 4 fixed = 68 total (was 70)
-0 ⚠️	checkstyle	0m 58s	/results-checkstyle-root.txt	root: The patch generated 2 new + 66 unchanged - 4 fixed = 68 total (was 70)
+1 💚	javadoc	1m 51s		the patch passed
+1 💚	spotbugs	9m 16s		the patch passed
			_ Other Tests _
+1 💚	unit	6m 2s		tez-dag in the patch passed.
+1 💚	unit	71m 42s		root in the patch passed.
+1 💚	asflicense	1m 3s		The patch does not generate ASF License warnings.
		134m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/3/artifact/out/Dockerfile
GITHUB PR	#463
Optional Tests	dupname asflicense javac javadoc unit codespell detsecrets xmllint compile spotbugs checkstyle
uname	Linux 21f09c8442b4 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-463/src/.yetus/personality.sh
git revision	master / `4aa2b66`
Default Java	Ubuntu-21.0.10+7-Ubuntu-124.04
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/3/testReport/
Max. process+thread count	1358 (vs. ulimit of 5500)
modules	C: tez-dag . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/3/console
versions	git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.4.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

abstractdog · 2026-03-11T10:47:06Z

changes look good to me, thanks a lot @Aggarwal-Raghav for fixing plexus-velocity bug! will merge this soon

Aggarwal-Raghav commented Mar 9, 2026

View reviewed changes

abstractdog self-requested a review March 9, 2026 11:06

Aggarwal-Raghav added 2 commits March 10, 2026 19:48

TEZ-4691: Upgrade maven-checkstyle-version to 3.6.0

63b412d

trigger checkstyle

4aa2b66

Aggarwal-Raghav force-pushed the TEZ-4691 branch from b7dddb9 to 4aa2b66 Compare March 10, 2026 14:19

abstractdog approved these changes Mar 11, 2026

View reviewed changes

Conversation

Aggarwal-Raghav commented Mar 9, 2026

Uh oh!

Aggarwal-Raghav Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

abstractdog commented Mar 9, 2026

Uh oh!

Aggarwal-Raghav commented Mar 9, 2026

Uh oh!

Aggarwal-Raghav commented Mar 9, 2026

Uh oh!

abstractdog commented Mar 9, 2026

Uh oh!

tez-yetus commented Mar 10, 2026

Uh oh!

abstractdog commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aggarwal-Raghav commented Mar 10, 2026

Uh oh!

tez-yetus commented Mar 10, 2026

Uh oh!

abstractdog commented Mar 10, 2026

Uh oh!

Aggarwal-Raghav commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tez-yetus commented Mar 10, 2026

Uh oh!

abstractdog commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abstractdog commented Mar 10, 2026 •

edited

Loading

Aggarwal-Raghav commented Mar 10, 2026 •

edited

Loading