Skip to content

THRIFT-5929: Fix build failure on PHP 8.5 due to removed zend_exception_get_default #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkvach wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

THRIFT-5929: Fix build failure on PHP 8.5 due to removed zend_exception_get_default #3350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
runs-on: ubuntu-24.04
strategy:
matrix:
php-version: [7.1, 7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3]
php-version: [7.1, 7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3, 8.4, 8.5]
fail-fast: false
steps:
- uses: actions/checkout@v6
Expand Down
2 changes: 1 addition & 1 deletion lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ void throw_tprotocolexception(const char* what, long errorcode) {
// Sets EG(exception), call this and then RETURN_NULL();
static
void throw_zend_exception_from_std_exception(const std::exception& ex) {
zend_throw_exception(zend_exception_get_default(), const_cast<char*>(ex.what()), 0);
zend_throw_exception(zend_ce_exception, const_cast<char*>(ex.what()), 0);
}

static
Expand Down