THRIFT-5930: c_glib: reject oversized Unix socket paths in thrift_server_socket_listen()#3354
Open
neosys007 wants to merge 1 commit intoapache:masterfrom
Open
THRIFT-5930: c_glib: reject oversized Unix socket paths in thrift_server_socket_listen()#3354neosys007 wants to merge 1 commit intoapache:masterfrom
neosys007 wants to merge 1 commit intoapache:masterfrom
Conversation
Jens-G
reviewed
Mar 24, 2026
compiler/cpp/src/thrift/main.cc
Outdated
| return nullptr; | ||
| } | ||
| strcpy(resolved_path, source); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
You are right to call this out, but this file should not be part of THRIFT-5930 in the first place. This PR branch accidentally pulled in the separate saferealpath change from THRIFT-5932. I will clean up #3354 so it only contains the c_glib server-socket changes.
…ver_socket_listen() thrift_server_socket_listen() still copies the configured Unix socket path directly into a stack sockaddr_un and then binds it. The path comes from a GObject property and is not checked against sizeof(pin.sun_path) before the copy.\n\nReject Unix socket paths that do not fit in the local sockaddr_un.sun_path buffer before building the sockaddr and binding the socket.
eba2263 to
69bb9b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the server-side Unix socket path copy in the C GLib transport.
In current head,
thrift_server_socket_listen()builds a stacksockaddr_unand copiestsocket->pathintosun_pathwithstrlen(path) + 1. That only works when the configured path is shorter than the destination buffer; otherwise the copy can run past the end of the localsockaddr_unbeforebind()is even called.The fix is intentionally small:
sizeof(struct sockaddr_un.sun_path)first,I also added regression coverage in
lib/c_glib/test/testtransportsocket.cthat checks the server listen path rejects an overlong Unix socket path cleanly.Validation performed locally:
git diff --checkRelated Jira: