THRIFT-5937: Fix generation of episodic nodejs for services#3361
Open
CJCombrink wants to merge 1 commit intoapache:masterfrom
Open
THRIFT-5937: Fix generation of episodic nodejs for services#3361CJCombrink wants to merge 1 commit intoapache:masterfrom
CJCombrink wants to merge 1 commit intoapache:masterfrom
Conversation
- Extending services from the episode must also take the episodes into account - Remove the reference in the generated ts for imported types since it can't be relative - Extend the tests
CJCombrink
force-pushed
the
bugfix_nodejs_episodic
branch
from
351703e to
dfa9121
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement episodic generation for service:
Extending services from the episode must also take the episodes into account
Remove the reference in the generated ts for imported types since it can't be relative
Extend the tests
Did you create an Apache Jira ticket? THRIFT-5937: nodejs episodic generation does not handle extending services
If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
Did you squash your changes to a single commit? (not required, but preferred)
Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
If your change does not involve any code, include
[skip ci]anywhere in the commit message to free up build resources.