Skip to content

Remove dependency on docker/login-action#3363

Open
zsy056 wants to merge 1 commit intoapache:masterfrom
zsy056:msvc-workflow
Open

Remove dependency on docker/login-action#3363
zsy056 wants to merge 1 commit intoapache:masterfrom
zsy056:msvc-workflow

Conversation

@zsy056
Copy link
Contributor

@zsy056 zsy056 commented Mar 25, 2026

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@mergeable mergeable bot added the github_actions Pull requests that update GitHub Actions code label Mar 25, 2026
@Jens-G
Copy link
Member

Jens-G commented Mar 27, 2026

Whats the purpose of this change?

@zsy056
Copy link
Contributor Author

zsy056 commented Mar 27, 2026

Whats the purpose of this change?

Hi Jens, it seems recently Apache org has enabled some policy that will block any unapproved GitHub Action like docker/login-action. This change removed that dependency so that this workflow can be run again.


permissions:
contents: read
packages: write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global write permission is considered a security risk. I would recommend to move it down to a specific job that needs write permissions.

See https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants